Add tests for empty input. Add typeof assertions. Increase test dataset size. Formatting.

diff --git a/src/System/Id/getSObjectType/System_Id_getSObjectType_TEST.cls b/src/System/Id/getSObjectType/System_Id_getSObjectType_TEST.cls
index 70d3f52684d413f11992bb718775341de544614b..c065ef2ae8d68267bef70f494e9981ec286c2ef6 100644 (file)
--- a/src/System/Id/getSObjectType/System_Id_getSObjectType_TEST.cls
+++ b/src/System/Id/getSObjectType/System_Id_getSObjectType_TEST.cls
@@ -17,34 +17,44 @@ private class System_Id_getSObjectType_TEST {
         Assert.areEqual(0, responses.size());\r
     }\r
 \r
+    @isTest\r
+    static void testEmptyRequest () {\r
+        List<System_Id_getSObjectType.Request> requests = new List<System_Id_getSObjectType.Request>();\r
+        System_Id_getSObjectType.Request req = new System_Id_getSObjectType.Request();\r
+        requests.add(req);\r
+\r
+        Test.startTest();\r
+        List<System_Id_getSObjectType.Response> responses = System_Id_getSObjectType.System_Id_getSObjectType(requests);\r
+        Test.stopTest();\r
+\r
+        Assert.areEqual(1, responses.size());\r
+        System_Id_getSObjectType.Response res = responses[0];\r
+        Assert.areEqual(null, res.sObjectType);\r
+    }\r
+\r
     @isTest\r
     static void testManyArgs () {\r
-        List<Account> listAccounts = new List<Account>();\r
-        for (Integer i = 0; i < 5; i++) {\r
+        List<Account> accounts = new List<Account>();\r
+        for (Integer i = 0; i < 100; i++) {\r
             Account a = new Account(\r
-                Name = 'Test Account ' + i,\r
-                BillingStreet = '123 Main Street',\r
-                BillingCity = 'New York',\r
-                BillingState = 'New York',\r
-                BillingPostalCode = '10001',\r
-                BillingCountry = 'United States'\r
+                Name = 'Test Account ' + i\r
             );\r
-            listAccounts.add(a);\r
+            accounts.add(a);\r
         }\r
-        insert listAccounts;\r
+        insert accounts;\r
 \r
         Test.startTest();\r
         List<System_Id_getSObjectType.Request> requests = new List<System_Id_getSObjectType.Request>();\r
-        for (Account a : listAccounts) {\r
+        for (Account a : accounts) {\r
             System_Id_getSObjectType.Request req = new System_Id_getSObjectType.Request(a.Id);\r
             requests.add(req);\r
         }\r
         List<System_Id_getSObjectType.Response> responses = System_Id_getSObjectType.System_Id_getSObjectType(requests);\r
         Test.stopTest();\r
 \r
-        Assert.areEqual(5, responses.size());\r
-        for (Integer i = 0; i < responses.size(); i++) {\r
-            System_Id_getSObjectType.Response res = responses[i];\r
+        Assert.areEqual(100, responses.size());\r
+        for (System_Id_getSObjectType.Response res : responses) {\r
+            Assert.isInstanceOfType(res.sObjectType, Schema_SObjectType.class);\r
             Assert.areEqual('Account', res.sObjectType.name);\r
         }\r
     }\r

diff --git a/src/System/Id/to15/System_Id_to15_TEST.cls b/src/System/Id/to15/System_Id_to15_TEST.cls
index 3a0f65539e994efb60ad3ea2b21e92e1caf1d290..59823fea4f5735220da6e7946cef3ca3d7c26f61 100644 (file)
--- a/src/System/Id/to15/System_Id_to15_TEST.cls
+++ b/src/System/Id/to15/System_Id_to15_TEST.cls
@@ -17,36 +17,47 @@ private class System_Id_to15_TEST {
         Assert.areEqual(0, responses.size());\r
     }\r
 \r
+    @isTest\r
+    static void testEmptyRequest () {\r
+        List<System_Id_to15.Request> requests = new List<System_Id_to15.Request>();\r
+        System_Id_to15.Request req = new System_Id_to15.Request();\r
+        requests.add(req);\r
+\r
+        Test.startTest();\r
+        List<System_Id_to15.Response> responses = System_Id_to15.System_Id_to15(requests);\r
+        Test.stopTest();\r
+\r
+        Assert.areEqual(1, responses.size());\r
+        System_Id_to15.Response res = responses[0];\r
+        Assert.areEqual(null, res.id);\r
+    }\r
+\r
     @isTest\r
     static void testManyArgs () {\r
-        List<Account> listAccounts = new List<Account>();\r
-        for (Integer i = 0; i < 5; i++) {\r
+        List<Account> accounts = new List<Account>();\r
+        for (Integer i = 0; i < 200; i++) {\r
             Account a = new Account(\r
-                Name = 'Test Account ' + i,\r
-                BillingStreet = '123 Main Street',\r
-                BillingCity = 'New York',\r
-                BillingState = 'New York',\r
-                BillingPostalCode = '10001',\r
-                BillingCountry = 'United States'\r
+                Name = 'Test Account ' + i\r
             );\r
-            listAccounts.add(a);\r
+            accounts.add(a);\r
         }\r
-        insert listAccounts;\r
+        insert accounts;\r
+        Map<Id, Account> accountMap = new Map<Id, Account>(accounts);\r
 \r
         Test.startTest();\r
         List<System_Id_to15.Request> requests = new List<System_Id_to15.Request>();\r
-        for (Account a : listAccounts) {\r
+        for (Account a : accountMap.values()) {\r
             System_Id_to15.Request req = new System_Id_to15.Request(a.Id);\r
             requests.add(req);\r
         }\r
         List<System_Id_to15.Response> responses = System_Id_to15.System_Id_to15(requests);\r
         Test.stopTest();\r
 \r
-        Assert.areEqual(5, responses.size());\r
-        for (Integer i = 0; i < responses.size(); i++) {\r
-            System_Id_to15.Response res = responses[i];\r
+        Assert.areEqual(200, responses.size());\r
+        for (System_Id_to15.Response res : responses) {\r
+            Assert.isInstanceOfType(res.id, String.class);\r
             Assert.areEqual(15, res.id.length());\r
-            Assert.areEqual(listAccounts[i].Id, res.id);\r
+            Assert.areEqual(accountMap.get(res.id).Id, Id.valueOf(res.id));\r
         }\r
     }\r
 }
\ No newline at end of file