From: Chris Duncan <chris@zoso.dev>
Date: Thu, 14 Aug 2025 13:15:31 +0000 (-0700)
Subject: Clarify intent of output buffer parameters with naming since there's not much to... 
X-Git-Tag: v0.10.5~41^2~102
X-Git-Url: https://git.codecow.com/?a=commitdiff_plain;h=11216f7314dbcd43e19a1e1b4a8f6864163676ad;p=libnemo.git

Clarify intent of output buffer parameters with naming since there's not much to be gained from shaving two characters if this is not fitting in 100 tweets.
---

diff --git a/src/lib/crypto/nano-nacl.ts b/src/lib/crypto/nano-nacl.ts
index d39c1cf..27c9625 100644
--- a/src/lib/crypto/nano-nacl.ts
+++ b/src/lib/crypto/nano-nacl.ts
@@ -34,7 +34,7 @@ export class NanoNaCl {
 		return (1 & ((d - 1) >>> 8)) - 1
 	}
 
-	static pow2523 (o: BigInt64Array, i: BigInt64Array): void {
+	static pow2523 (out: BigInt64Array, i: BigInt64Array): void {
 		const c: BigInt64Array = new BigInt64Array(16)
 		c.set(i.subarray(0, 16), 0)
 		for (let a = 0; a < 249; a++) {
@@ -44,21 +44,21 @@ export class NanoNaCl {
 		this.Square(c, c)
 		this.Square(c, c)
 		this.Multiply(c, c, i)
-		o.set(c, 0)
+		out.set(c, 0)
 	}
 
-	static car25519 (o: BigInt64Array): void {
+	static car25519 (out: BigInt64Array): void {
 		let v, c, s = 1n << 16n
 		c = 0n
 		for (let i = 0; i < 16; i++) {
-			v = o[i] + c + s
-			o[i] = v % s
+			v = out[i] + c + s
+			out[i] = v % s
 			c = v / s - 1n
 		}
-		o[0] += 38n * c
+		out[0] += 38n * c
 	}
 
-	static inv25519 (o: BigInt64Array, i: BigInt64Array): void {
+	static inv25519 (out: BigInt64Array, i: BigInt64Array): void {
 		const c: BigInt64Array = new BigInt64Array(16)
 		c.set(i.subarray(0, 16), 0)
 		for (let a = 253; a >= 0; a--) {
@@ -67,7 +67,7 @@ export class NanoNaCl {
 				this.Multiply(c, c, i)
 			}
 		}
-		o.set(c, 0)
+		out.set(c, 0)
 	}
 
 	static neq25519 (a: BigInt64Array, b: BigInt64Array): number {
@@ -78,7 +78,7 @@ export class NanoNaCl {
 		return this.#vn(c, 0, d, 0, 32)
 	}
 
-	static pack25519 (o: Uint8Array, n: BigInt64Array): void {
+	static pack25519 (out: Uint8Array, n: BigInt64Array): void {
 		let b: bigint
 		const m: BigInt64Array = new BigInt64Array(16)
 		const t: BigInt64Array = new BigInt64Array(16)
@@ -98,8 +98,8 @@ export class NanoNaCl {
 			this.sel25519(t, m, 1n - b)
 		}
 		for (let i = 0; i < 16; i++) {
-			o[2 * i] = Number(t[i] & 0xffn)
-			o[2 * i + 1] = Number(t[i] >> 8n)
+			out[2 * i] = Number(t[i] & 0xffn)
+			out[2 * i + 1] = Number(t[i] >> 8n)
 		}
 	}
 
@@ -119,26 +119,26 @@ export class NanoNaCl {
 		}
 	}
 
-	static unpack25519 (o: BigInt64Array, n: Uint8Array): void {
+	static unpack25519 (out: BigInt64Array, n: Uint8Array): void {
 		for (let i = 0; i < 16; i++) {
-			o[i] = BigInt(n[2 * i]) + (BigInt(n[2 * i + 1]) << 8n)
+			out[i] = BigInt(n[2 * i]) + (BigInt(n[2 * i + 1]) << 8n)
 		}
-		o[15] &= (1n << 15n) - 1n
+		out[15] &= (1n << 15n) - 1n
 	}
 
-	static Add (o: BigInt64Array, a: BigInt64Array, b: BigInt64Array): void {
+	static Add (out: BigInt64Array, a: BigInt64Array, b: BigInt64Array): void {
 		for (let i = 0; i < 16; i++) {
-			o[i] = a[i] + b[i]
+			out[i] = a[i] + b[i]
 		}
 	}
 
-	static Subtract (o: BigInt64Array, a: BigInt64Array, b: BigInt64Array): void {
+	static Subtract (out: BigInt64Array, a: BigInt64Array, b: BigInt64Array): void {
 		for (let i = 0; i < 16; i++) {
-			o[i] = a[i] - b[i]
+			out[i] = a[i] - b[i]
 		}
 	}
 
-	static Multiply (o: BigInt64Array, a: BigInt64Array, b: BigInt64Array): void {
+	static Multiply (out: BigInt64Array, a: BigInt64Array, b: BigInt64Array): void {
 		let v, c, s: bigint = 1n << 16n
 		const t: BigInt64Array = new BigInt64Array(31)
 		t.fill(0n)
@@ -174,10 +174,10 @@ export class NanoNaCl {
 		t[0] += 38n * c
 
 		// assign result to output
-		o.set(t.slice(0, 16), 0)
+		out.set(t.slice(0, 16), 0)
 	}
 
-	static Square (o: BigInt64Array, a: BigInt64Array): void {
+	static Square (out: BigInt64Array, a: BigInt64Array): void {
 		let v, c, s: bigint = 1n << 16n
 		const t: BigInt64Array = new BigInt64Array(31)
 		t.fill(0n)
@@ -214,7 +214,7 @@ export class NanoNaCl {
 		t[0] += 38n * c
 
 		// assign result to output
-		o.set(t.slice(0, 16), 0)
+		out.set(t.slice(0, 16), 0)
 	}
 
 	static add (p: BigInt64Array[], q: BigInt64Array[]): void {