From: Loup Vaillant <loup@loup-vaillant.fr>
Date: Fri, 19 Feb 2021 13:33:58 +0000 (+0100)
Subject: Argon2i: remove useless intermediate block
X-Git-Url: https://git.codecow.com/?a=commitdiff_plain;h=2338603f8c118e6d57b9fc5e44c388347a92dc6e;p=Monocypher.git

Argon2i: remove useless intermediate block
---

diff --git a/src/monocypher.c b/src/monocypher.c
index fd07388..06f9522 100644
--- a/src/monocypher.c
+++ b/src/monocypher.c
@@ -954,22 +954,18 @@ void crypto_argon2i_general(u8       *hash,      u32 hash_size,
         crypto_blake2b_final(&ctx, initial_hash);
 
         // fill first 2 blocks
-        block tmp_block;
-        u8    hash_area[1024];
+        u8 hash_area[1024];
         store32_le(initial_hash + 64, 0); // first  additional word
         store32_le(initial_hash + 68, 0); // second additional word
         extended_hash(hash_area, 1024, initial_hash, 72);
-        load_block(&tmp_block, hash_area);
-        copy_block(blocks, &tmp_block);
+        load_block(blocks, hash_area);
 
         store32_le(initial_hash + 64, 1); // slight modification
         extended_hash(hash_area, 1024, initial_hash, 72);
-        load_block(&tmp_block, hash_area);
-        copy_block(blocks + 1, &tmp_block);
+        load_block(blocks + 1, hash_area);
 
         WIPE_BUFFER(initial_hash);
         WIPE_BUFFER(hash_area);
-        wipe_block(&tmp_block);
     }
 
     // Actual number of blocks