From: Loup Vaillant <loup@loup-vaillant.fr>
Date: Sun, 13 Mar 2022 09:57:52 +0000 (+0100)
Subject: Removed redundant Valgrind tests
X-Git-Url: https://git.codecow.com/?a=commitdiff_plain;h=a2ffd4da78bac6756e132095a5231fd57f1f11a7;p=Monocypher.git

Removed redundant Valgrind tests

I think we don't need to test both -O2 and -O3. We're checking memory
error here, they should not be much different under different
optimisation settings (though maybe -O3 can trigger more bugs).

Also did not add myself to the list of authors, I think this trivial
change is not copyrightable.
---

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index a6182ab..74ba013 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -148,14 +148,6 @@ jobs:
       - name: Build, then run with valgrind (OK without march=native)
         run: |
 
-          echo "Valgrind on GCC build with O2"
-          make clean; make test.out CFLAGS="-O2" -j4
-          valgrind ./test.out
-
-          echo "Valgrind on CLANG build with O2"
-          make clean; make test.out CC="clang -std=c99" CFLAGS="-O2" -j4
-          valgrind ./test.out
-
           echo "Valgrind on GCC build with O3"
           make clean; make test.out CFLAGS="-O3" -j4
           valgrind ./test.out