From 034afd192923fee314e6aebc7cfcd8103eb21ed4 Mon Sep 17 00:00:00 2001 From: Loup Vaillant Date: Sun, 24 Sep 2017 15:19:03 +0200 Subject: [PATCH] Corrected bogus EdDSA coverage test (stack smashing undefined behaviour) --- tests/test.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/test.c b/tests/test.c index f2f9b06..cf70cd7 100644 --- a/tests/test.c +++ b/tests/test.c @@ -619,12 +619,12 @@ static int p_eddsa_overlap() FOR(i, 0, MESSAGE_SIZE + 64) { #undef INPUT_SIZE #define INPUT_SIZE (MESSAGE_SIZE + (2 * 64)) // total input size - u8 sk [32]; p_random(sk, 32); - u8 pk [32]; crypto_sign_public_key(pk, sk); - u8 input [INPUT_SIZE]; p_random(input, INPUT_SIZE); + RANDOM_INPUT(input, INPUT_SIZE); + RANDOM_INPUT(sk , 32 ); + u8 pk [32]; crypto_sign_public_key(pk, sk); u8 signature[64]; - crypto_sign(signature, sk, pk, input + 64, SHA_512_BLOCK_SIZE); - crypto_sign(input+i , sk, pk, input + 64, SHA_512_BLOCK_SIZE); + crypto_sign(signature, sk, pk, input + 64, MESSAGE_SIZE); + crypto_sign(input+i , sk, pk, input + 64, MESSAGE_SIZE); status |= crypto_memcmp(signature, input + i, 64); } printf("%s: EdDSA (overlap)\n", status != 0 ? "FAILED" : "OK"); -- 2.47.3