From 5e080d03f8edca730fbc5dd8f7f7c063dd27d546 Mon Sep 17 00:00:00 2001 From: Chris Duncan Date: Fri, 5 Jul 2024 00:54:20 -0700 Subject: [PATCH] Fix descriptions, delete unnecessary whitespace, and update test variable names for consistency. --- .../System_Id_getSObjectType.cls | 2 +- .../System_Id_getSObjectType_TEST.cls | 34 ++++++++++--------- src/System/Id/to15/System_Id_to15.cls | 4 +-- src/System/Id/to15/System_Id_to15_TEST.cls | 33 ++++++++++-------- 4 files changed, 39 insertions(+), 34 deletions(-) diff --git a/src/System/Id/getSObjectType/System_Id_getSObjectType.cls b/src/System/Id/getSObjectType/System_Id_getSObjectType.cls index bab0f42..6704f27 100644 --- a/src/System/Id/getSObjectType/System_Id_getSObjectType.cls +++ b/src/System/Id/getSObjectType/System_Id_getSObjectType.cls @@ -3,7 +3,7 @@ * SPDX-License-Identifier: GPL-3.0-or-later */ - global class System_Id_getSObjectType { +global class System_Id_getSObjectType { @InvocableMethod(label='System.Id.getSObjectType()' category='Flowpex' iconName='slds:utility:record_lookup' description='Returns the token for the sObject corresponding to this ID. This method is primarily used with describe information.') diff --git a/src/System/Id/getSObjectType/System_Id_getSObjectType_TEST.cls b/src/System/Id/getSObjectType/System_Id_getSObjectType_TEST.cls index 0cdb2f3..70d3f52 100644 --- a/src/System/Id/getSObjectType/System_Id_getSObjectType_TEST.cls +++ b/src/System/Id/getSObjectType/System_Id_getSObjectType_TEST.cls @@ -3,18 +3,18 @@ * SPDX-License-Identifier: GPL-3.0-or-later */ - @isTest +@isTest private class System_Id_getSObjectType_TEST { @isTest static void testNoArgs () { - List req = new List(); + List requests = new List(); Test.startTest(); - List res = System_Id_getSObjectType.System_Id_getSObjectType(req); + List responses = System_Id_getSObjectType.System_Id_getSObjectType(requests); Test.stopTest(); - Assert.areEqual(0, res.size()); + Assert.areEqual(0, responses.size()); } @isTest @@ -22,28 +22,30 @@ private class System_Id_getSObjectType_TEST { List listAccounts = new List(); for (Integer i = 0; i < 5; i++) { Account a = new Account( - Name = 'Test Account ' + i, - BillingStreet = '123 Main Street', - BillingCity = 'New York', - BillingState = 'New York', - BillingPostalCode = '10001', - BillingCountry = 'United States' + Name = 'Test Account ' + i, + BillingStreet = '123 Main Street', + BillingCity = 'New York', + BillingState = 'New York', + BillingPostalCode = '10001', + BillingCountry = 'United States' ); listAccounts.add(a); } insert listAccounts; Test.startTest(); - List listSystem_Id_getSObjectTypeRequest = new List(); + List requests = new List(); for (Account a : listAccounts) { - listSystem_Id_getSObjectTypeRequest.add(new System_Id_getSObjectType.Request(a.Id)); + System_Id_getSObjectType.Request req = new System_Id_getSObjectType.Request(a.Id); + requests.add(req); } - List results = System_Id_getSObjectType.System_Id_getSObjectType(listSystem_Id_getSObjectTypeRequest); + List responses = System_Id_getSObjectType.System_Id_getSObjectType(requests); Test.stopTest(); - Assert.areEqual(5, results.size()); - for (Integer i = 0; i < results.size(); i++) { - Assert.areEqual('Account', results[i].sObjectType.name); + Assert.areEqual(5, responses.size()); + for (Integer i = 0; i < responses.size(); i++) { + System_Id_getSObjectType.Response res = responses[i]; + Assert.areEqual('Account', res.sObjectType.name); } } } \ No newline at end of file diff --git a/src/System/Id/to15/System_Id_to15.cls b/src/System/Id/to15/System_Id_to15.cls index 498b455..16767fe 100644 --- a/src/System/Id/to15/System_Id_to15.cls +++ b/src/System/Id/to15/System_Id_to15.cls @@ -19,7 +19,7 @@ global class System_Id_to15 { } global class Request { - @InvocableVariable(label='ID' required='true' description='The 18-character ID value to be converted.') + @InvocableVariable(label='ID' required='true' description='18-character ID value to be converted.') global String id; global Request () {} @@ -29,7 +29,7 @@ global class System_Id_to15 { } global class Response { - @InvocableVariable(label='SObject Type' description='The 15-character case-sensitive version of the ID.') + @InvocableVariable(label='ID' description='15-character case-sensitive version of the ID.') global String id; } } \ No newline at end of file diff --git a/src/System/Id/to15/System_Id_to15_TEST.cls b/src/System/Id/to15/System_Id_to15_TEST.cls index 73093f7..3a0f655 100644 --- a/src/System/Id/to15/System_Id_to15_TEST.cls +++ b/src/System/Id/to15/System_Id_to15_TEST.cls @@ -8,13 +8,13 @@ private class System_Id_to15_TEST { @isTest static void testNoArgs () { - List req = new List(); + List requests = new List(); Test.startTest(); - List res = System_Id_to15.System_Id_to15(req); + List responses = System_Id_to15.System_Id_to15(requests); Test.stopTest(); - Assert.areEqual(0, res.size()); + Assert.areEqual(0, responses.size()); } @isTest @@ -22,28 +22,31 @@ private class System_Id_to15_TEST { List listAccounts = new List(); for (Integer i = 0; i < 5; i++) { Account a = new Account( - Name = 'Test Account ' + i, - BillingStreet = '123 Main Street', - BillingCity = 'New York', - BillingState = 'New York', - BillingPostalCode = '10001', - BillingCountry = 'United States' + Name = 'Test Account ' + i, + BillingStreet = '123 Main Street', + BillingCity = 'New York', + BillingState = 'New York', + BillingPostalCode = '10001', + BillingCountry = 'United States' ); listAccounts.add(a); } insert listAccounts; Test.startTest(); - List listSystem_Id_to15Request = new List(); + List requests = new List(); for (Account a : listAccounts) { - listSystem_Id_to15Request.add(new System_Id_to15.Request(a.Id)); + System_Id_to15.Request req = new System_Id_to15.Request(a.Id); + requests.add(req); } - List results = System_Id_to15.System_Id_to15(listSystem_Id_to15Request); + List responses = System_Id_to15.System_Id_to15(requests); Test.stopTest(); - Assert.areEqual(5, results.size()); - for (Integer i = 0; i < results.size(); i++) { - Assert.areEqual(listAccounts[i].Id, results[i].id); + Assert.areEqual(5, responses.size()); + for (Integer i = 0; i < responses.size(); i++) { + System_Id_to15.Response res = responses[i]; + Assert.areEqual(15, res.id.length()); + Assert.areEqual(listAccounts[i].Id, res.id); } } } \ No newline at end of file -- 2.52.0