From 9194d2bdb3709e6524db7d0b3bb965f935c70e2c Mon Sep 17 00:00:00 2001
From: Chris Duncan <chris@flowpex.dev>
Date: Thu, 11 Jul 2024 13:49:28 -0700
Subject: [PATCH] Add tests for empty input. Add typeof assertions. Increase
 test dataset size. Formatting.

---
 .../System_Id_getSObjectType_TEST.cls         | 38 ++++++++++-------
 src/System/Id/to15/System_Id_to15_TEST.cls    | 41 ++++++++++++-------
 2 files changed, 50 insertions(+), 29 deletions(-)

diff --git a/src/System/Id/getSObjectType/System_Id_getSObjectType_TEST.cls b/src/System/Id/getSObjectType/System_Id_getSObjectType_TEST.cls
index 70d3f52..c065ef2 100644
--- a/src/System/Id/getSObjectType/System_Id_getSObjectType_TEST.cls
+++ b/src/System/Id/getSObjectType/System_Id_getSObjectType_TEST.cls
@@ -17,34 +17,44 @@ private class System_Id_getSObjectType_TEST {
         Assert.areEqual(0, responses.size());
     }
 
+    @isTest
+    static void testEmptyRequest () {
+        List<System_Id_getSObjectType.Request> requests = new List<System_Id_getSObjectType.Request>();
+        System_Id_getSObjectType.Request req = new System_Id_getSObjectType.Request();
+        requests.add(req);
+
+        Test.startTest();
+        List<System_Id_getSObjectType.Response> responses = System_Id_getSObjectType.System_Id_getSObjectType(requests);
+        Test.stopTest();
+
+        Assert.areEqual(1, responses.size());
+        System_Id_getSObjectType.Response res = responses[0];
+        Assert.areEqual(null, res.sObjectType);
+    }
+
     @isTest
     static void testManyArgs () {
-        List<Account> listAccounts = new List<Account>();
-        for (Integer i = 0; i < 5; i++) {
+        List<Account> accounts = new List<Account>();
+        for (Integer i = 0; i < 100; i++) {
             Account a = new Account(
-                Name = 'Test Account ' + i,
-                BillingStreet = '123 Main Street',
-                BillingCity = 'New York',
-                BillingState = 'New York',
-                BillingPostalCode = '10001',
-                BillingCountry = 'United States'
+                Name = 'Test Account ' + i
             );
-            listAccounts.add(a);
+            accounts.add(a);
         }
-        insert listAccounts;
+        insert accounts;
 
         Test.startTest();
         List<System_Id_getSObjectType.Request> requests = new List<System_Id_getSObjectType.Request>();
-        for (Account a : listAccounts) {
+        for (Account a : accounts) {
             System_Id_getSObjectType.Request req = new System_Id_getSObjectType.Request(a.Id);
             requests.add(req);
         }
         List<System_Id_getSObjectType.Response> responses = System_Id_getSObjectType.System_Id_getSObjectType(requests);
         Test.stopTest();
 
-        Assert.areEqual(5, responses.size());
-        for (Integer i = 0; i < responses.size(); i++) {
-            System_Id_getSObjectType.Response res = responses[i];
+        Assert.areEqual(100, responses.size());
+        for (System_Id_getSObjectType.Response res : responses) {
+            Assert.isInstanceOfType(res.sObjectType, Schema_SObjectType.class);
             Assert.areEqual('Account', res.sObjectType.name);
         }
     }
diff --git a/src/System/Id/to15/System_Id_to15_TEST.cls b/src/System/Id/to15/System_Id_to15_TEST.cls
index 3a0f655..59823fe 100644
--- a/src/System/Id/to15/System_Id_to15_TEST.cls
+++ b/src/System/Id/to15/System_Id_to15_TEST.cls
@@ -17,36 +17,47 @@ private class System_Id_to15_TEST {
         Assert.areEqual(0, responses.size());
     }
 
+    @isTest
+    static void testEmptyRequest () {
+        List<System_Id_to15.Request> requests = new List<System_Id_to15.Request>();
+        System_Id_to15.Request req = new System_Id_to15.Request();
+        requests.add(req);
+
+        Test.startTest();
+        List<System_Id_to15.Response> responses = System_Id_to15.System_Id_to15(requests);
+        Test.stopTest();
+
+        Assert.areEqual(1, responses.size());
+        System_Id_to15.Response res = responses[0];
+        Assert.areEqual(null, res.id);
+    }
+
     @isTest
     static void testManyArgs () {
-        List<Account> listAccounts = new List<Account>();
-        for (Integer i = 0; i < 5; i++) {
+        List<Account> accounts = new List<Account>();
+        for (Integer i = 0; i < 200; i++) {
             Account a = new Account(
-                Name = 'Test Account ' + i,
-                BillingStreet = '123 Main Street',
-                BillingCity = 'New York',
-                BillingState = 'New York',
-                BillingPostalCode = '10001',
-                BillingCountry = 'United States'
+                Name = 'Test Account ' + i
             );
-            listAccounts.add(a);
+            accounts.add(a);
         }
-        insert listAccounts;
+        insert accounts;
+        Map<Id, Account> accountMap = new Map<Id, Account>(accounts);
 
         Test.startTest();
         List<System_Id_to15.Request> requests = new List<System_Id_to15.Request>();
-        for (Account a : listAccounts) {
+        for (Account a : accountMap.values()) {
             System_Id_to15.Request req = new System_Id_to15.Request(a.Id);
             requests.add(req);
         }
         List<System_Id_to15.Response> responses = System_Id_to15.System_Id_to15(requests);
         Test.stopTest();
 
-        Assert.areEqual(5, responses.size());
-        for (Integer i = 0; i < responses.size(); i++) {
-            System_Id_to15.Response res = responses[i];
+        Assert.areEqual(200, responses.size());
+        for (System_Id_to15.Response res : responses) {
+            Assert.isInstanceOfType(res.id, String.class);
             Assert.areEqual(15, res.id.length());
-            Assert.areEqual(listAccounts[i].Id, res.id);
+            Assert.areEqual(accountMap.get(res.id).Id, Id.valueOf(res.id));
         }
     }
 }
\ No newline at end of file
-- 
2.52.0